Fix some issues with fhirpath expression evaluation #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly handle delimited identifiers - Propagate the `permissive` option properly and through children() and descendants() by adding it to the context - Handle primitive Xhtml type - Fix IsCodeField() to return true for CodeType fields by checking annotation instead of suffix (i.e. DocumentReference_RelatesTo_CodeType)
Quarz0
requested review from
AlexJSully,
VickSuresh,
alexlaurinmath,
bitwizeshift and
jonhayesverily
Author
|
Added another commit to fix a small issue in bundleresolver.go's getLatestResource() function where it currently returns the oldest resource instead of the most recent |
VickSuresh
reviewed
Nov 10, 2025
VickSuresh
reviewed
Nov 10, 2025
VickSuresh
reviewed
Nov 10, 2025
VickSuresh
reviewed
Nov 10, 2025
Contributor
|
@Quarz0 If you have capacity to resolve the comments, that would be appreciated :) Otherwise, we'll work on getting this out for the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permissiveoption properly and through children() and descendants() by adding it to the context