fix: Avoid deep copying in ModelContainer to resolve pickling errors#14
Open
laksi1999 wants to merge 1 commit intoveritas-toolkit:masterfrom
Open
fix: Avoid deep copying in ModelContainer to resolve pickling errors#14laksi1999 wants to merge 1 commit intoveritas-toolkit:masterfrom
ModelContainer to resolve pickling errors#14laksi1999 wants to merge 1 commit intoveritas-toolkit:masterfrom
Conversation
ModelContainer to resolve pickling errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The original implementation of the
ModelContainerclass relied on deep copying experiment objects stored in themodel_objectattribute. This approach led to"cannot pickle"errors when dealing with certain objects that are not serializable, such as those from the Driverless AI. This limitation hindered users from integrating their models seamlessly, particularly when using tools that are popular in the community.Proposed Solution
model_objectsparameter, allowing users to pass pre-created model objects directly into theModelContainer.model_object.model_objectslist that contains pre-created instances.model_object.ModelWrapperare created and passed directly, thereby avoiding serialization problems.Note: Importantly, the existing logic for using a single
model_objectremains intact, allowing users to continue using the ModelContainer as they did previously without any required changes.