-
Notifications
You must be signed in to change notification settings - Fork 193
Add support for exporting to ONNX. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…uring ONNX dynamic shape inference
|
Im slightly busy with graduation this week, I will be back to work on this by the weekend |
No problem, thanks for letting me know. Congratulations on your graduation! |
|
Hi @acai66 @IamShubhamGupto , Thank you very much for providing the ONNX examples in both C++ and Python. They look amazing and incredibly useful! Are you still waiting for @IamShubhamGupto to review the merge? I am not sure if you both merged the work you did last month, so I am just checking in to see if I should start reviewing the PR. Once again, thank you @acai66 and @IamShubhamGupto for the ONNX examples. I appreciate your effort to make XFeat deployment much better! |
Thank you for checking in. I am still waiting for @IamShubhamGupto's review. Unfortunately, I haven't received any response from @IamShubhamGupto regarding last month's work, which might be due to the busy graduation season. |
Hey @acai66 @guipotje sorry to keep both of you waiting. I did just graduate and was busy with a few conferences and competitions. As for the development on this branch, I believe you should go ahead and merge this branch. I will be back on contributing to this project some time later. |
|
@acai66 Hi, thank you for your contribution. I found that only |
|
@acai66 Thank you very much! |
|
@acai66 Have you met a problem in |
|
Hey @acai66, thanks for all your work on the ONNX export of XFeat, it's been very handy. @guipotje recently added the Lighterglue addon matcher so I spent some time to make that available for ONNX export on top of your changes, see the branch here: https://github.com/stschake/accelerated_features/tree/feature/lighterglue-onnx The upstream code uses kornia which isn't suitable for ONNX export, so I started with the LightGlue-ONNX implementation and modified it slightly to add things like keypoints normalization directly in the model, in the xfeat tradition. |
|
Thanks guys! Looking forward for onnx version. |
|
excellent work, why is it not merged yet? |
|
Looks good, can it be merged? Are there still any open issues? |

xfeat.onnxxfeat_dualscale.onnxmatching.onnxxfeat_matching.onnxonnx_models.zip
examples
accelerated_features/realtime_demo.py
Line 239 in b2f6b99
xfeat_onnxruntime.py
realtime_demo.py patches