Conversation
ibc
reviewed
Feb 24, 2025
Member
There was a problem hiding this comment.
I'm amazed that this fix looks too obvious to never have realized of it. I mean, we were literally dropping packets in MANY SCENARIOS without dropping then in SeqManager. How is possible that we never noticed it?
Please add entry in CHANGELOG.
Also minimal cosmetic changes.
And ASAN checks are failing in CI.
Member
Member
|
I'm updating the branch with pending changes in v3. |
Member
All those are caused by the new |
ibc
reviewed
Feb 24, 2025
ibc
approved these changes
Feb 24, 2025
ibc
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the given sequence number if the RTP packet cannot be forwarded.
Fixes #1069
By not doing so, we are incorrectly generating non legitimate sequence number jumps which involves:
This problem is very apparent when using BWE and the available BW is low enough to discard a lot of packets, or when the outgoing bitrate is manually set low enough too.