Conversation
…to current spatial layer ## Details - Fixes #1547.
jmillan
reviewed
Jun 26, 2025
jmillan
reviewed
Jun 26, 2025
jmillan
requested changes
Jun 26, 2025
Member
jmillan
left a comment
jmillan
left a comment
There was a problem hiding this comment.
PR is fine. Just please check my comments and put the discard logs back in place. Feel free to rename RtcLogger.Dropped() by RtcLogger.Discarded().
jmillan
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
rtpSeqManager->Drop(seq)if the packet doesn't belong to the current spatial layer. Why? Because if we callDrop(seq)inSimulcastConsumerno matter the spatial layer (AKA SSRC stream) we are polluting our singlertpSeqManagerwith drops of unrelated seq numbers, and this could perfectly break the ongoing continuous RTP stream.SimpleConsumeretc. it's not just about simulcast.XxxxConsumerclasses.PipeConsumer.cpp.Bonus Tracks
RtcLogger::Drop()toRtcLogger::Discard()andDropReasontoDiscardReason. This is because we want to only use "drop" term when we also callDrop()on the RTP sequence manager while there are packets that are discarded without involving any action in the RTP sequence manager.inlinekeywords inXxxxConsumer.cppfiles because they are completely useless in 2025.