Conversation
…LIs/FIRs when RTP packets containing a key frame arrive out of order ## Details - Fixes #1547. - Add a `targetLayerRetransmissionBuffer` to `Consumer` classes that holds RTP packets that presumably may contains chunks of a key frame so if they arrive before the first key frame packet (due to packets arriving out of order) they will be immediately sent once the first packet arrives. - Without this it may happen that a chunk of the key frame arrives before the first chunk of the key frame and it would be completely discarded so when later the receiver sends NACK we could not retransmit it, triggering a full PLI from the receiver and hence causing black video for a while. - For more details see the rlated issue #1547.
jmillan
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
targetLayerRetransmissionBuffertoConsumerclasses that holds RTP packets that presumably may contains chunks of a key frame so if they arrive before the first key frame packet (due to packets arriving out of order) they will be immediately sent once the first packet arrives.Bonus Tracks
RtcLogger.hppin files that use it.ms_xxxxoptions enabled.