Skip to content

RtcLogger: Use MS_DUMP() instead of std::cout() #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmillan merged 6 commits into from
Jun 28, 2025
Merged

RtcLogger: Use MS_DUMP() instead of std::cout() #1553

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e40a4c3
RtcLogger: Use MS_DUMP() instead of std::cout()
jmillan Jun 26, 2025
c379a29
Update CHANGELOG
jmillan Jun 26, 2025
3c2d64b
feedback
jmillan Jun 27, 2025
ed738d4
feedback
jmillan Jun 27, 2025
5d9fb7c
feedback
jmillan Jun 27, 2025
fd9be37
revert changes in CHANGELOG
jmillan Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions worker/src/RTC/RtcLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include "RTC/RtcLogger.hpp"
#include "Logger.hpp"
#include <sstream>

namespace RTC
{
Expand Down Expand Up @@ -52,42 +53,41 @@ namespace RTC
{
MS_TRACE();

// TODO: Here we are using std::cout() which means that it's directly
// written to stdout. When in Node, it means that Worker.ts captures it
// and prints it ONLY if DEBUG env contains "Worker", and it prefixes the
// log with "(stdout)". We should move to MS_DUMP() or MS_DUMP_CLEAN().
std::stringstream ss;

std::cout << "{";
std::cout << "\"timestamp\": " << this->timestamp;
ss << "{";
ss << "\"timestamp\": " << this->timestamp;

if (!this->recvTransportId.empty())
{
std::cout << R"(, "recvTransportId": ")" << this->recvTransportId << "\"";
ss << R"(, "recvTransportId": ")" << this->recvTransportId << "\"";
}
if (!this->sendTransportId.empty())
{
std::cout << R"(, "sendTransportId": ")" << this->sendTransportId << "\"";
ss << R"(, "sendTransportId": ")" << this->sendTransportId << "\"";
}
if (!this->routerId.empty())
{
std::cout << R"(, "routerId": ")" << this->routerId << "\"";
ss << R"(, "routerId": ")" << this->routerId << "\"";
}
if (!this->producerId.empty())
{
std::cout << R"(, "producerId": ")" << this->producerId << "\"";
ss << R"(, "producerId": ")" << this->producerId << "\"";
}
if (!this->consumerId.empty())
{
std::cout << R"(, "consumerId": ")" << this->consumerId << "\"";
ss << R"(, "consumerId": ")" << this->consumerId << "\"";
}

std::cout << ", \"recvRtpTimestamp\": " << this->recvRtpTimestamp;
std::cout << ", \"sendRtpTimestamp\": " << this->sendRtpTimestamp;
std::cout << ", \"recvSeqNumber\": " << this->recvSeqNumber;
std::cout << ", \"sendSeqNumber\": " << this->sendSeqNumber;
std::cout << ", \"discarded\": " << (this->discarded ? "true" : "false");
std::cout << ", \"discardReason\": '" << discardReason2String[this->discardReason] << "'";
std::cout << "}" << std::endl;
ss << ", \"recvRtpTimestamp\": " << this->recvRtpTimestamp;
ss << ", \"sendRtpTimestamp\": " << this->sendRtpTimestamp;
ss << ", \"recvSeqNumber\": " << this->recvSeqNumber;
ss << ", \"sendSeqNumber\": " << this->sendSeqNumber;
ss << ", \"discarded\": " << (this->discarded ? "true" : "false");
ss << ", \"discardReason\": '" << discardReason2String[this->discardReason] << "'";
ss << "}";

MS_DUMP("%s", ss.str().c_str());
}

void RtpPacket::Clear()
Expand Down