Merged
Conversation
* fix classpath issue in `runMod` task * make `vertx.gradle` compatible with recent changes in groovy * use https when connecting with sonatype * add explicit dependencies and pin versions
|
merge this please |
|
is this repo dead or is there an specific reason that you dont update the gradle version? |
Member
|
I didn't know about this because my GitHub notifications were until recently getting swallowed by my spam filter :( |
|
thanks ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runModtaskvertx.gradlecompatible with recent changes in groovyPR is inspired by #32, #37, #36, #29 and most importantly #31.
If this PR gets accepted,
runModtask should run way more smoothly and be more resilient to custom environment settings than before. JRuby still remains very fickle even compared to minor differences in build environments, but that is definitely outside the scope of this PR.Anyway, I am open for ideas or suggestions.
Btw: I signed the Eclipse CLA (User: madler6j2).