Fix request absolute URI handling #2833
Open
+77
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes vert-x3#2830
tsegismont
reviewed
Dec 15, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
There seems to be a compilation problem. Can you take a look?
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request:
The result of HttpServerRequest.absoluteURI() would then be:
http://www.example.com:1234www.example.com:1234/pathWith this change, when the request target is absolute, only the path (and query) are added to the Host value:
http://www.example.com:1234/pathFixes #2830