Trezor support and misc fixes.#47
Open
jhoenicke wants to merge 4 commits intovertcoin-project:masterfrom
Open
Conversation
Vovka19
reviewed
Jan 22, 2018
Vovka19
left a comment
Vovka19
left a comment
There was a problem hiding this comment.
Thank you! I will try. I just learning. Too difficult for me! Too much thank you, i thought nobody answer. :)))
|
Trezor FW 1.6.1 already have Vertcoin, can you merge this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few things (BIP-44 path: vertcoin uses 28, Sign message prefix) and the TREZOR plugin.
Note that TREZOR support needs at the moment a self-compiled firmware for TREZOR with vertcoin support added.
I had to enable the hardware support option. It may be useful to disable keepkey or ledger support, if they don't work yet.
I only did minimal testing (receiving a coin, sending a transaction with one input, two outputs, no multisig, no segwit).