1- Contributing to Bitcoin Core
1+ Contributing to Vertcoin Core
22============================
33
4- The Bitcoin Core project operates an open contributor model where anyone is
4+ The Vertcoin Core project operates an open contributor model where anyone is
55welcome to contribute towards development in the form of peer review, testing
66and patches. This document explains the practical process and guidelines for
77contributing.
@@ -15,62 +15,16 @@ merging pull requests, as well as a "lead maintainer" who is responsible for the
1515release cycle as well as overall merging, moderation and appointment of
1616maintainers.
1717
18- Getting Started
19- ---------------
20-
21- New contributors are very welcome and needed.
22-
23- Reviewing and testing is highly valued and the most effective way you can contribute
24- as a new contributor. It also will teach you much more about the code and
25- process than opening pull requests. Please refer to the [ peer review] ( #peer-review )
26- section below.
27-
28- Before you start contributing, familiarize yourself with the Bitcoin Core build
29- system and tests. Refer to the documentation in the repository on how to build
30- Bitcoin Core and how to run the unit tests, functional tests, and fuzz tests.
31-
32- There are many open issues of varying difficulty waiting to be fixed.
33- If you're looking for somewhere to start contributing, check out the
34- [ good first issue] ( https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 )
35- list or changes that are
36- [ up for grabs] ( https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=label%3A%22Up+for+grabs%22 ) .
37- Some of them might no longer be applicable. So if you are interested, but
38- unsure, you might want to leave a comment on the issue first.
39-
40- You may also participate in the weekly
41- [ Bitcoin Core PR Review Club] ( https://bitcoincore.reviews/ ) meeting.
42-
43- ### Good First Issue Label
44-
45- The purpose of the ` good first issue ` label is to highlight which issues are
46- suitable for a new contributor without a deep understanding of the codebase.
47-
48- However, good first issues can be solved by anyone. If they remain unsolved
49- for a longer time, a frequent contributor might address them.
50-
51- You do not need to request permission to start working on an issue. However,
52- you are encouraged to leave a comment if you are planning to work on it. This
53- will help other contributors monitor which issues are actively being addressed
54- and is also an effective way to request assistance if and when you need it.
55-
5618Communication Channels
5719----------------------
5820
59- Most communication about Bitcoin Core development happens on IRC, in the
60- ` #bitcoin-core-dev ` channel on Libera Chat. The easiest way to participate on IRC is
61- with the web client, [ web.libera.chat] ( https://web.libera.chat/#bitcoin-core-dev ) . Chat
62- history logs can be found
63- on [ http://www.erisian.com.au/bitcoin-core-dev/ ] ( http://www.erisian.com.au/bitcoin-core-dev/ )
64- and [ http://gnusha.org/bitcoin-core-dev/ ] ( http://gnusha.org/bitcoin-core-dev/ ) .
21+ Most communication about Vertcoin Core development happens onthe #development channel
22+ on [ Discord] ( https://discord.gg/vertcoin ) .
6523
66- Discussion about codebase improvements happens in GitHub issues and pull
67- requests.
68-
69- The developer
70- [ mailing list] ( https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev )
71- should be used to discuss complicated or controversial consensus or P2P protocol changes before working on
72- a patch set.
24+ Issues List
25+ --------------------
7326
27+ Open issues can be found on github in the [ issues list] ( https://github.com/vertcoin-project/vertcoin-core/issues ) .
7428
7529Contributor Workflow
7630--------------------
@@ -136,51 +90,6 @@ about Git.
13690 - Push changes to your fork
13791 - Create pull request
13892
139- ### Creating the Pull Request
140-
141- The title of the pull request should be prefixed by the component or area that
142- the pull request affects. Valid areas as:
143-
144- - ` consensus ` for changes to consensus critical code
145- - ` doc ` for changes to the documentation
146- - ` qt ` or ` gui ` for changes to bitcoin-qt
147- - ` log ` for changes to log messages
148- - ` mining ` for changes to the mining code
149- - ` net ` or ` p2p ` for changes to the peer-to-peer network code
150- - ` refactor ` for structural changes that do not change behavior
151- - ` rpc ` , ` rest ` or ` zmq ` for changes to the RPC, REST or ZMQ APIs
152- - ` script ` for changes to the scripts and tools
153- - ` test ` , ` qa ` or ` ci ` for changes to the unit tests, QA tests or CI code
154- - ` util ` or ` lib ` for changes to the utils or libraries
155- - ` wallet ` for changes to the wallet code
156- - ` build ` for changes to the GNU Autotools or reproducible builds
157-
158- Examples:
159-
160- consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG
161- net: Automatically create onion service, listen on Tor
162- qt: Add feed bump button
163- log: Fix typo in log message
164-
165- The body of the pull request should contain sufficient description of * what* the
166- patch does, and even more importantly, * why* , with justification and reasoning.
167- You should include references to any discussions (for example, other issues or
168- mailing list discussions).
169-
170- The description for a new pull request should not contain any ` @ ` mentions. The
171- PR description will be included in the commit message when the PR is merged and
172- any users mentioned in the description will be annoyingly notified each time a
173- fork of Bitcoin Core copies the merge. Instead, make any username mentions in a
174- subsequent comment to the PR.
175-
176- ### Translation changes
177-
178- Note that translations should not be submitted as pull requests. Please see
179- [ Translation Process] ( https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md )
180- for more information on helping with translations.
181-
182- ### Work in Progress Changes and Requests for Comments
183-
18493If a pull request is not to be considered for merging (yet), please
18594prefix the title with [ WIP] or use [ Tasks Lists] ( https://help.github.com/articles/basic-writing-and-formatting-syntax/#task-lists )
18695in the body of the pull request to indicate tasks are pending.
@@ -223,209 +132,10 @@ the respective change set.
223132The length of time required for peer review is unpredictable and will vary from
224133pull request to pull request.
225134
226- ### Rebasing Changes
227-
228- When a pull request conflicts with the target branch, you may be asked to rebase it on top of the current target branch.
229- The ` git rebase ` command will take care of rebuilding your commits on top of the new base.
230-
231- This project aims to have a clean git history, where code changes are only made in non-merge commits. This simplifies
232- auditability because merge commits can be assumed to not contain arbitrary code changes. Merge commits should be signed,
233- and the resulting git tree hash must be deterministic and reproducible. The script in
234- [ /contrib/verify-commits] ( /contrib/verify-commits ) checks that.
235-
236- After a rebase, reviewers are encouraged to sign off on the force push. This should be relatively straightforward with
237- the ` git range-diff ` tool explained in the [ productivity
238- notes] ( /doc/productivity.md#diff-the-diffs-with-git-range-diff ) . To avoid needless review churn, maintainers will
239- generally merge pull requests that received the most review attention first.
240-
241- Pull Request Philosophy
242- -----------------------
243-
244- Patchsets should always be focused. For example, a pull request could add a
245- feature, fix a bug, or refactor code; but not a mixture. Please also avoid super
246- pull requests which attempt to do too much, are overly large, or overly complex
247- as this makes review difficult.
248-
249-
250- ### Features
251-
252- When adding a new feature, thought must be given to the long term technical debt
253- and maintenance that feature may require after inclusion. Before proposing a new
254- feature that will require maintenance, please consider if you are willing to
255- maintain it (including bug fixing). If features get orphaned with no maintainer
256- in the future, they may be removed by the Repository Maintainer.
257-
258-
259- ### Refactoring
260-
261- Refactoring is a necessary part of any software project's evolution. The
262- following guidelines cover refactoring pull requests for the project.
263-
264- There are three categories of refactoring: code-only moves, code style fixes, and
265- code refactoring. In general, refactoring pull requests should not mix these
266- three kinds of activities in order to make refactoring pull requests easy to
267- review and uncontroversial. In all cases, refactoring PRs must not change the
268- behaviour of code within the pull request (bugs must be preserved as is).
269-
270- Project maintainers aim for a quick turnaround on refactoring pull requests, so
271- where possible keep them short, uncomplex and easy to verify.
272-
273- Pull requests that refactor the code should not be made by new contributors. It
274- requires a certain level of experience to know where the code belongs to and to
275- understand the full ramification (including rebase effort of open pull requests).
276-
277- Trivial pull requests or pull requests that refactor the code with no clear
278- benefits may be immediately closed by the maintainers to reduce unnecessary
279- workload on reviewing.
280-
281-
282- "Decision Making" Process
283- -------------------------
284-
285- The following applies to code changes to the Bitcoin Core project (and related
286- projects such as libsecp256k1), and is not to be confused with overall Bitcoin
287- Network Protocol consensus changes.
288-
289- Whether a pull request is merged into Bitcoin Core rests with the project merge
290- maintainers and ultimately the project lead.
291-
292- Maintainers will take into consideration if a patch is in line with the general
293- principles of the project; meets the minimum standards for inclusion; and will
294- judge the general consensus of contributors.
295-
296- In general, all pull requests must:
297-
298- - Have a clear use case, fix a demonstrable bug or serve the greater good of
299- the project (for example refactoring for modularisation);
300- - Be well peer-reviewed;
301- - Have unit tests, functional tests, and fuzz tests, where appropriate;
302- - Follow code style guidelines ([ C++] ( doc/developer-notes.md ) , [ functional tests] ( test/functional/README.md ) );
303- - Not break the existing test suite;
304- - Where bugs are fixed, where possible, there should be unit tests
305- demonstrating the bug and also proving the fix. This helps prevent regression.
306- - Change relevant comments and documentation when behaviour of code changes.
307-
308- Patches that change Bitcoin consensus rules are considerably more involved than
309- normal because they affect the entire ecosystem and so must be preceded by
310- extensive mailing list discussions and have a numbered BIP. While each case will
311- be different, one should be prepared to expend more time and effort than for
312- other kinds of patches because of increased peer review and consensus building
313- requirements.
314-
315-
316- ### Peer Review
317-
318- Anyone may participate in peer review which is expressed by comments in the pull
319- request. Typically reviewers will review the code for obvious errors, as well as
320- test out the patch set and opine on the technical merits of the patch. Project
321- maintainers take into account the peer review when determining if there is
322- consensus to merge a pull request (remember that discussions may have been
323- spread out over GitHub, mailing list and IRC discussions).
324-
325- #### Conceptual Review
326-
327- A review can be a conceptual review, where the reviewer leaves a comment
328- * ` Concept (N)ACK ` , meaning "I do (not) agree with the general goal of this pull
329- request",
330- * ` Approach (N)ACK ` , meaning ` Concept ACK ` , but "I do (not) agree with the
331- approach of this change".
332-
333- A ` NACK ` needs to include a rationale why the change is not worthwhile.
334- NACKs without accompanying reasoning may be disregarded.
335-
336- #### Code Review
337-
338- After conceptual agreement on the change, code review can be provided. A review
339- begins with ` ACK BRANCH_COMMIT ` , where ` BRANCH_COMMIT ` is the top of the PR
340- branch, followed by a description of how the reviewer did the review. The
341- following language is used within pull request comments:
342-
343- - "I have tested the code", involving change-specific manual testing in
344- addition to running the unit, functional, or fuzz tests, and in case it is
345- not obvious how the manual testing was done, it should be described;
346- - "I have not tested the code, but I have reviewed it and it looks
347- OK, I agree it can be merged";
348- - A "nit" refers to a trivial, often non-blocking issue.
349-
350- Project maintainers reserve the right to weigh the opinions of peer reviewers
351- using common sense judgement and may also weigh based on merit. Reviewers that
352- have demonstrated a deeper commitment and understanding of the project over time
353- or who have clear domain expertise may naturally have more weight, as one would
354- expect in all walks of life.
355-
356- Where a patch set affects consensus-critical code, the bar will be much
357- higher in terms of discussion and peer review requirements, keeping in mind that
358- mistakes could be very costly to the wider community. This includes refactoring
359- of consensus-critical code.
360-
361- Where a patch set proposes to change the Bitcoin consensus, it must have been
362- discussed extensively on the mailing list and IRC, be accompanied by a widely
363- discussed BIP and have a generally widely perceived technical consensus of being
364- a worthwhile change based on the judgement of the maintainers.
365-
366- ### Finding Reviewers
367-
368- As most reviewers are themselves developers with their own projects, the review
369- process can be quite lengthy, and some amount of patience is required. If you find
370- that you've been waiting for a pull request to be given attention for several
371- months, there may be a number of reasons for this, some of which you can do something
372- about:
373-
374- - It may be because of a feature freeze due to an upcoming release. During this time,
375- only bug fixes are taken into consideration. If your pull request is a new feature,
376- it will not be prioritized until after the release. Wait for the release.
377- - It may be because the changes you are suggesting do not appeal to people. Rather than
378- nits and critique, which require effort and means they care enough to spend time on your
379- contribution, thundering silence is a good sign of widespread (mild) dislike of a given change
380- (because people don't assume * others* won't actually like the proposal). Don't take
381- that personally, though! Instead, take another critical look at what you are suggesting
382- and see if it: changes too much, is too broad, doesn't adhere to the
383- [ developer notes] ( doc/developer-notes.md ) , is dangerous or insecure, is messily written, etc.
384- Identify and address any of the issues you find. Then ask e.g. on IRC if someone could give
385- their opinion on the concept itself.
386- - It may be because your code is too complex for all but a few people, and those people
387- may not have realized your pull request even exists. A great way to find people who
388- are qualified and care about the code you are touching is the
389- [ Git Blame feature] ( https://help.github.com/articles/tracing-changes-in-a-file/ ) . Simply
390- look up who last modified the code you are changing and see if you can find
391- them and give them a nudge. Don't be incessant about the nudging, though.
392- - Finally, if all else fails, ask on IRC or elsewhere for someone to give your pull request
393- a look. If you think you've been waiting for an unreasonably long time (say,
394- more than a month) for no particular reason (a few lines changed, etc.),
395- this is totally fine. Try to return the favor when someone else is asking
396- for feedback on their code, and the universe balances out.
397- - Remember that the best thing you can do while waiting is give review to others!
398-
399-
400- Backporting
401- -----------
402-
403- Security and bug fixes can be backported from ` master ` to release
404- branches.
405- If the backport is non-trivial, it may be appropriate to open an
406- additional PR to backport the change, but only after the original PR
407- has been merged.
408- Otherwise, backports will be done in batches and
409- the maintainers will use the proper ` Needs backport (...) ` labels
410- when needed (the original author does not need to worry about it).
411-
412- A backport should contain the following metadata in the commit body:
413-
414- ```
415- Github-Pull: #<PR number>
416- Rebased-From: <commit hash of the original commit>
417- ```
418-
419- Have a look at [ an example backport PR] (
420- https://github.com/bitcoin/bitcoin/pull/16189 ).
421-
422- Also see the [ backport.py script] (
423- https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport ).
424-
425135Release Policy
426136--------------
427137
428- The project leader is the release manager for each Bitcoin Core release.
138+ The project leader is the release manager for each Vertcoin Core release.
429139
430140Copyright
431141---------
0 commit comments