Open
Conversation
o0Ignition0o
force-pushed
the
igni/windowstests
branch
from
ce18a58 to
1b28531
Compare
o0Ignition0o
force-pushed
the
igni/windowstests
branch
from
1b28531 to
d8570f7
Compare
Because @vertexclique keeps breaking stuff
OtaK
suggested changes
Aug 3, 2020
| agnostik = "0.1.3" | ||
| pin-utils = "0.1.0" | ||
| socket2 = {version = "0.3.12", features = ["pair", "unix"]} | ||
| winapi = "0.3.9" |
There was a problem hiding this comment.
Suggested change
| winapi = "0.3.9" | |
| winapi = { version = "0.3.9", default-features = false } |
Then add each feature as needed, that will drastically reduce compile times.
| #[derive(Copy, Clone)] | ||
| pub struct WinHandle(HANDLE); | ||
|
|
||
| // TODO [igni]: SUPER CURSED THIS NEEDS TO GO AWAY |
There was a problem hiding this comment.
Actually it might not be that cursed on windows versions newer than 10. The default threadpool allows HWNDs to cross FFI bounds safely because all of the api calls are ran on the system-owned threadpool.
Owner
There was a problem hiding this comment.
4 years later, i learn this again. I will dive into this sometime soon folks. I will apply partial patches from this PR, since structure has changed since years. cc/ @o0Ignition0o
| entries_stuff, | ||
| &mut stuff.key(), | ||
| entries_removed, | ||
| 1, // TODO: Play around with that on poll or something. |
There was a problem hiding this comment.
This lacks a last parameter: fAlertable (https://docs.microsoft.com/en-us/windows/win32/fileio/getqueuedcompletionstatusex-func)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.