new-mut-ref: more precise analysis for mut refs with loops#2143
Open
new-mut-ref: more precise analysis for mut refs with loops#2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, we can't handle the following when new-mut-ref is enabled:
The problem is that
agets havoc'ed by the loop, so we need a loop invariant thatmut_ref_future(a) == mut_ref_future(old(a)). This is a pretty big usability problem, as well as a major backwards compatibility issue.The problem is fundamentally similar to something like this failing:
The problem in both cases is that our analysis for havoc'ing vars across loops works on the coarse granularity of local variables and doesn't consider individual fields.
To fix this, I enhance our analysis to compute a "HavocSet", a finer grained set of subplaces, rather than a set of local variables. This system is currently special-cased to only handle the mut-ref issue (i.e. to fix test case
test) but still doesn't track fields for structs or tuples in general (i.e., we don't addresstest2). However, I aimed to write the new code in a generic way that could be easily extended in the future.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.