fix: handle several reachable panics#2180
Open
Marsman1996 wants to merge 3 commits intoverus-lang:mainfrom
Open
fix: handle several reachable panics#2180Marsman1996 wants to merge 3 commits intoverus-lang:mainfrom
Marsman1996 wants to merge 3 commits intoverus-lang:mainfrom
Conversation
Contributor
Author
|
0fb8fd9 to
aa36232
Compare
tjhance
requested changes
Feb 14, 2026
Collaborator
There was a problem hiding this comment.
the bitwise operator change looks fine; the other 2 are internal errors (the expected invariants on verus's internal state are being violated) so they need further investigation. I'd appreciate it if (in addition to this PR) you could:
- leave #2175 open
- file an additional issue with the closure "missing return type" example
thanks!
aa36232 to
13ecc5a
Compare
This was referenced Feb 15, 2026
Contributor
Author
See #2184 |
13ecc5a to
147b89f
Compare
Contributor
Author
|
The new commit fixes #2174 just like verus/source/rust_verify/src/rust_to_vir_base.rs Line 2328 in ac50b8f and verus/source/rust_verify/src/rust_to_vir_base.rs Line 1791 in ac50b8f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles #2175, #2184 and more
Fix #2174
My pipeline depends on Verus returning errors in JSON format.
When Verus panics, no JSON message is produced, which breaks the pipeline.
This PR changes the behavior to return a structured error message instead of panicking.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.