Skip to content

don't compile Regex in frequently called function get_rust_item #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2024
Merged

don't compile Regex in frequently called function get_rust_item #971

merged 3 commits into from
Feb 5, 2024

Conversation

tjhance
Copy link
Collaborator

@tjhance tjhance commented Feb 2, 2024

Savings are significant; on the mem-allocator project, rust-to-vir goes down from nearly 2s. to 0.3s.

@tjhance tjhance requested a review from utaal February 2, 2024 20:40
@utaal-b utaal-b requested review from utaal-b and removed request for utaal February 5, 2024 12:12
@utaal-b
Copy link
Contributor

utaal-b commented Feb 5, 2024

This is a tiny dependency, but just in case we can avoid it: would the OnceCells introduced here be sufficient? rust-lang/rust#105587

@tjhance tjhance merged commit 2aed333 into main Feb 5, 2024
@tjhance tjhance deleted the lazy-regex branch February 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@utaal-b utaal-b utaal-b approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjhance @utaal-b