Fix unassign_variable warning#2298
Merged
dalance merged 1 commit intoveryl-lang:masterfrom Mar 6, 2026
Merged
Conversation
taichi-ishitani
commented
Mar 6, 2026
| pub func_paths: HashMap<FuncPath, VarId>, | ||
| pub variables: HashMap<VarId, Variable>, | ||
| pub functions: HashMap<VarId, Function>, | ||
| pub func_call_depth: u32, |
Contributor
Author
There was a problem hiding this comment.
func_call_depth is not used so I removed it.
taichi-ishitani
force-pushed
the
fix_unassigned_variable
branch
from
23b0b28 to
6b9adf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2297
The caller context should be used to extract the given local function but an empty context is used.
Due to this, a
constused in the function can't be found andunassign_variableis reported becuaseforloop in the function can't be evaluated.To fix this issue, the given context should be used if the given function is a local function.