feat: dynamically export and set gitref metadata#26
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces hardcoded git reference extraction with a dynamic loop that processes all commits from the JSON response, improving scalability as new repositories are added to the system.
Key Changes:
- Replaced two hardcoded
jqextractions for specific repos with awhileloop that iterates over all commits - Dynamic variable naming that converts repo names to uppercase with underscores for environment variables
- Maintains backward compatibility by creating the same metadata keys in buildkite
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
esolitos
force-pushed
the
marlon/feat/dynamic-gitref-export
branch
5 times, most recently
from
2e225fb to
3ea8bf6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace hardcoded extraction of git references with a loop that processes all commits in JSON. Export environment variables for each repo using uppercase and underscore naming, and set corresponding buildkite metadata dynamically. This improves scalability and maintainability as new repos are added without modifying the script.
esolitos
force-pushed
the
marlon/feat/dynamic-gitref-export
branch
from
3ea8bf6 to
1ea7272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why