fix(deploy): S3 bucket name variable #1786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esolitos
temporarily deployed
to
Vespa Cloud CD
GitHub Actions
Inactive
lperry25
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates to the
.github/workflows/update-cloud-samples.ymlworkflow:s/S3_BUCKET/AWS_S3_BUCKET_NAME/Why
.
Bonus: Click here for Copilot PR review
Workflow improvements:
DRY_RUNenvironment variable to control dry-run behavior based on the event type and branch, with a note to remove it once a separate S3 bucket is used for the 'Vespa Cloud CD' environment.DRY_RUNvariable viaAWS_S3_OPTIONS, ensuring dry-run mode is correctly applied.DRY_RUNvariable through theECHOenvironment variable, making the dry-run logic consistent across the workflow.