Skip to content

Conversation

@zoharsan
Copy link
Contributor

@zoharsan zoharsan commented Nov 7, 2025

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

zoharsan and others added 2 commits November 7, 2025 11:34
Removed the instruction to continue to the querying section after deployment.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new sample application demonstrating Retrieval Augmented Generation (RAG) using AWS Bedrock models in Vespa. The application builds upon the MS Marco passage ranking example and showcases how to integrate AWS Bedrock's OpenAI-compatible API with Vespa's RAG capabilities.

Key changes:

  • Added a new aws-simple-rag sample application with configuration for AWS Bedrock integration
  • Implemented hybrid search combining BM25 text search and vector similarity using the E5 embedder
  • Provided comprehensive documentation for setup, deployment, and querying with AWS Bedrock models

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
aws-simple-rag/services.xml Defines Vespa service configuration including the HuggingFace E5 embedder, AWS Bedrock OpenAI client setup, and RAG search chain
aws-simple-rag/schemas/passage.sd Schema definition for passage documents with text and embedding fields, plus hybrid ranking profile
aws-simple-rag/README.md Comprehensive documentation covering AWS Bedrock setup, Vespa deployment, feeding data, and querying with RAG
aws-simple-rag/.vespaignore Configuration to exclude unnecessary files from the Vespa application package
aws-simple-rag/ext/edit-app-access.png Screenshot showing how to grant application access to secrets in Vespa Cloud Console
README.md Added reference to the new AWS Bedrock RAG sample application in the main repository README

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kkraune
kkraune previously approved these changes Nov 10, 2025
Copy link
Member

@kkraune kkraune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I would consider moving it to the examples directory instead of the root, to keep things a little more organized.

I left some of the indentation suggestions below for your review and commit

Removed outdated section on RAG in Vespa with AWS Bedrock models. as moving it examples subdirectory
@zoharsan
Copy link
Contributor Author

@kkraune I moved the directory to examples.

@zoharsan zoharsan requested review from Copilot and kkraune November 10, 2025 19:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kkraune kkraune merged commit a571c2b into master Nov 11, 2025
8 checks passed
@kkraune kkraune deleted the zoharsan/aws-simple-rag branch November 11, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants