Address test duplication concern regarding AcceptHeaderMatcher quality value testing#35512
Closed
Copilot wants to merge 1 commit intoandreer/cbor-content-negotiationfrom
Closed
Address test duplication concern regarding AcceptHeaderMatcher quality value testing#35512Copilot wants to merge 1 commit intoandreer/cbor-content-negotiationfrom
Copilot wants to merge 1 commit intoandreer/cbor-content-negotiationfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix testing duplication in CBOR content negotiation
Address test duplication concern regarding AcceptHeaderMatcher quality value testing
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #35509 regarding potential test duplication. The question was whether adding quality value tests to
SearchHandlerTestwould duplicate coverage already inAcceptHeaderMatcherTest.Resolution
No code changes required. The current test structure is appropriate:
AcceptHeaderMatcherTestprovides comprehensive unit tests for quality value parsing and preference ordering (lines 49-71)SearchHandlerTestprovides integration tests verifying end-to-end Accept header handling in the search handlerAcceptHeaderMatcherand callingpreferredExactMediaTypes()), so detailed quality value scenarios belong in the unit testsAdding quality value tests to the integration layer would duplicate existing unit test coverage without adding value.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.