Skip to content

Fix PositiveInfinityResultNode returns positive infinity#35967

Open
johansolbakken wants to merge 2 commits intomasterfrom
johsol/fix-positive-infinity
Open

Fix PositiveInfinityResultNode returns positive infinity#35967
johansolbakken wants to merge 2 commits intomasterfrom
johsol/fix-positive-infinity

Conversation

@johansolbakken
Copy link
Contributor

  • grouping_adv system tests worked.

@arnej27959 please review

arnej27959
arnej27959 previously approved these changes Feb 19, 2026
Copy link
Member

@arnej27959 arnej27959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code
std::numeric_limits<int64_t>::infinity()
doesn't really do what one would guess, so either keep it as 0
or consider using max() instead.
Also, I think we can use the "new" way to ignore the index parameter here.
My suggested change may break some unit test, please check if you want to use it.

Co-authored-by: Arne H Juul <arnej27959@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments