optionally prefer Dockerfile.alma8 and Dockerfile.alma9#36037
Merged
arnej27959 merged 1 commit intomasterfrom Feb 26, 2026
Merged
optionally prefer Dockerfile.alma8 and Dockerfile.alma9#36037arnej27959 merged 1 commit intomasterfrom
arnej27959 merged 1 commit intomasterfrom
Conversation
Add a select_dockerfile function to .buildkite/build-container.sh that
picks an OS-specific Dockerfile when one is available. If a file named
Dockerfile.${VESPA_BUILDOS_LABEL} exists in the build context (e.g.
Dockerfile.alma8 or Dockerfile.alma9), it is used instead of the default
Dockerfile. Both docker build invocations in the script now use this
function, allowing OS-variant-specific image builds while keeping full
backward compatibility with the existing default Dockerfile.
esolitos
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a select_dockerfile function to .buildkite/build-container.sh that picks an OS-specific Dockerfile when one is available. If a file named Dockerfile.${VESPA_BUILDOS_LABEL} exists in the build context (e.g. Dockerfile.alma8 or Dockerfile.alma9), it is used instead of the default Dockerfile. Both docker build invocations in the script now use this function, allowing OS-variant-specific image builds while keeping full backward compatibility with the existing default Dockerfile.