build-container: include Maven from wrapper#36079
Closed
arnej27959 wants to merge 2 commits intomasterfrom
Closed
Conversation
Before building the Vespa preview container, locate the Maven distribution that was downloaded by the Maven wrapper (~/.m2/wrapper/dists/apache-maven-*) and copy it into share/maven/ so that the exact wrapper-managed Maven version is available to the container build.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Buildkite container build script to bundle the Maven distribution downloaded by the Maven wrapper into the Docker build context, aiming to make the container build use the exact wrapper-managed Maven version.
Changes:
- Add a step to locate a Maven wrapper distribution under
~/.m2/wrapper/dists/. - Copy the detected Maven distribution into
share/maven/before building the Vespa preview container. - Log the presence of the copied
share/maven/bin/mvn.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
we'll do this another way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before building the Vespa preview container, locate the Maven distribution that was downloaded by the Maven wrapper (~/.m2/wrapper/dists/apache-maven-*) and copy it into share/maven/ so that the exact wrapper-managed Maven version is available to the container build.