Skip to content

Conversation

@YuJin44
Copy link

@YuJin44 YuJin44 commented Mar 23, 2024

#65

Copy link

@kopax kopax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is not readable, there is everything reformated, is it possible to revert, and edit with vim so you don't get any reformat and we can see the lines that fixe ?

@YuJin44
Copy link
Author

YuJin44 commented Mar 24, 2024

oh sorry, I messed up there a bit. somehow managed to make CRLF out of LF. Anyway, done now. There is only 1 commit now without format change.

@vesse
Copy link
Owner

vesse commented Jun 6, 2024

Sorry I've been really lazy with this whole project. But this is something I cannot verify to work but you have tried this in real life use? The code looks correct though.

@YuJin44
Copy link
Author

YuJin44 commented Jun 6, 2024

Yes, I am actually using it already with the Requarks/Wiki (requarks/wiki#3599) and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants