Async options retrieval error is handled through this.error()#108
Open
ddolcimascolo wants to merge 1 commit intovesse:masterfrom
Open
Async options retrieval error is handled through this.error()#108ddolcimascolo wants to merge 1 commit intovesse:masterfrom
ddolcimascolo wants to merge 1 commit intovesse:masterfrom
Conversation
Author
|
Ping @vesse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vesse
I came accross this while working on LDAP auth for one of our products. Our use case is to query a DNS SRV record in order to obtain the address of the server. I definitely think that if the
getOptionsfunction errors out, the error should be propagated as such and not hidden as an authentication failure. The authentication did not happen yet.WDYT ?
This would be a breaking change, though I'm unsure of the impact as most users should already handle errors fine anyway...
Thanks !
David