Conversation
I've added initial tests and ability to compile with sanitizers enabled.
I've added a detector type for charge integrators. Not yet implemented in the ROOT tree output
I've added the trigger type and sort type to the UserConfiguration as these runtime options can be useful to know while sorting data.
Added a check to determine if the resulting block of events are larger than 0, if not we will not commit it to the queue
I've added the option to pass along all blocks of entries if the sort type is gap and trigger is any.
We now have a charge integrator spectrum and a bug fix as the code was assuming unsigned int for index, while we were passing a signed int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support/spectra for charge integrators to types of detectors. The PR also fixes quite a few bugs. See the commit logs for more details.