Upgrade CAPO version to v0.12.2 (v2) #165
Open
+49,104
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CAPO version v0.11.2 there is a severe bug allowing to accomplish Denial of Service by any tenant. Manual removal of VM by tenant which is managed by CAPO results in a pod crash in a loop. This has been fixed with [1] and is part of the 0.12.2 release. Signed-off-by: Dmitriy Rabotyagov <[email protected]>
More modern CAPO also requires corresponding CAPI , otherwise VM creation fails with: `no matches for kind \"Image\" in version \"openstack.k-orc.cloud/v1alpha1\` Signed-off-by: Dmitriy Rabotyagov <[email protected]>
CAPO 0.12.0 has removed ORC [1] and now it needs to be installed additionally. [1] https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/tag/v0.12.0 Signed-off-by: Dmitriy Rabotyagov <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
|
The approach I rather take here is a new role specific for the k-orc since it's just a dependency, so I'm going to add a new role to this and add it as a dependency instead. I'll see if we can use Kustomize as well. |
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
|
alright, it's working great now, I just have to add the @jrosser @noonedeadpunk lmk if this is looking good, i dont think it should break you and keeps things nice and organized. |
Signed-off-by: Yaguang Tang <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
Signed-off-by: Mohammed Naser <[email protected]>
|
alright, this should sort out all of the issues surrounding pre-commit and linters.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CAPO version v0.11.2 there is a severe bug allowing to accomplish
Denial of Service by any tenant.
Manual removal of VM by tenant which is managed by CAPO results
in a pod crash in a loop. This has been fixed with [1] and is part
of the 0.12.2 release.
This is alternative patch to #152 due to messing up with introduction
of DCO requirement.
[1] kubernetes-sigs/cluster-api-provider-openstack#2477