fix dns server list issue when specified with more than one#501
Closed
Yaguang Tang (yaguangtang) wants to merge 1 commit intovexxhost:mainfrom
Closed
fix dns server list issue when specified with more than one#501Yaguang Tang (yaguangtang) wants to merge 1 commit intovexxhost:mainfrom
Yaguang Tang (yaguangtang) wants to merge 1 commit intovexxhost:mainfrom
Conversation
Mohammed Naser (mnaser)
requested changes
Feb 21, 2025
Comment on lines
2049
to
2055
| """\ | ||
| - cidr: {{ .nodeCidr }} | ||
| dnsNameservers: {{ .dnsNameservers }} | ||
| dnsNameservers: | ||
| {{- range .dnsNameservers }} | ||
| - {{ . }} | ||
| {{- end }} | ||
| """ |
There was a problem hiding this comment.
I think we should create a functional test for this to test the behaviour when 1 or many DNS servers are being included and make sure that it propagates properly. There are examples of this already
In magnum template when specify more than one dns servers,the cluster using that template fail to create due to dns list being regard as string.
Yaguang Tang (yaguangtang)
force-pushed
the
fix-dns-list-issue
branch
from
8405b69 to
58bb734
Compare
Member
|
This is covered in the Rust refactor in #519 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In magnum template when specify more than one dns servers,the cluster using that template fail to create due to dns list being regard as string
https://github.com/gophercloud/gophercloud/blob/main/openstack/networking/v2/subnets/requests.go#L125C1-L125C60