fix: rewrite UDP forwarding and add CI tests#41
Open
Mohammed Naser (mnaser) wants to merge 1 commit intomainfrom
Open
fix: rewrite UDP forwarding and add CI tests#41Mohammed Naser (mnaser) wants to merge 1 commit intomainfrom
Mohammed Naser (mnaser) wants to merge 1 commit intomainfrom
Conversation
- Extract forwardUDP as a standalone testable function - Fix connection leak: single DialUDP per session instead of per-packet - Fix defer accumulation: defer at function scope, not inside loop - Fix stuck goroutines: sync.OnceFunc closes both connections when either direction fails - Use 65535-byte buffers (max UDP) instead of 1500 (MTU-limited) - Add TestForwardUDP with localhost UDP echo server - Update CI to use robherley/go-test-action with concurrency control Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
UDP forwarding fixes
forwardUDPas a standalone testable functionDialUDPper session instead of per-packetdeferat function scope, not inside loopsync.OnceFunccloses both connections when either direction failsTesting
TestForwardUDPwith localhost UDP echo server validating bidirectional forwarding and clean shutdownCI
go build main.gowithrobherley/go-test-action(covers build + test with PR annotations)workflow_dispatchtrigger