fix: don't crash on empty frontmatter#7
Merged
wooorm merged 4 commits intovfile:mainfrom Mar 19, 2025
Merged
Conversation
Hey! Small fix in case someone tries to parse an empty frontmatter: ```md ---- ---- I'm a file ``` In this case, match[1] is undefined, so fallback to an empty string Signed-off-by: Gautier Ben Aïm <48261497+GauBen@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
🤞 phase/open
remcohaszing
approved these changes
Mar 18, 2025
wooorm
reviewed
Mar 19, 2025
Signed-off-by: Titus <tituswormer@gmail.com>
wooorm
approved these changes
Mar 19, 2025
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks, released in https://github.com/vfile/vfile-matter/releases/tag/5.0.1! |
Contributor
Author
|
Thanks! |
bfdes
added a commit
to bfdes/bfdes.in
that referenced
this pull request
Mar 22, 2025
bfdes
added a commit
to bfdes/bfdes.in
that referenced
this pull request
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Hey!
Small fix in case someone tries to parse an empty frontmatter:
In this case, match[1] is undefined, so fallback to an empty string