Skip to content

Conversation

@lena-kuhn
Copy link

Started equipping this great implementation of rake algorithm with docstrings according to the numpydoc guide. If you see fit, I can extend writing docstrings to algorithm.py and stopwords.py

Copy link
Owner

@vgrabovets vgrabovets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for your work.
Could you, please, also fix really small issues with code style: https://travis-ci.org/vgrabovets/multi_rake/builds/573329575
Here is how to run checks locally: https://github.com/vgrabovets/multi_rake#development
If you want to continue, I would be really grateful. Just ping me when you're done and I will merge it and release to pypi.

Parameters
----------
text : utf8Bytes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be str, shouldn't it?



def separate_words(text):
"""Seperate text to tokens by whitespace and dimiss numeric tokens.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos: separate, dismiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants