Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void UsefulAnalyzer::AnalyzeCFGBlock(const CFGBlock& block) { | ||
| for (auto ib = block.end(); ib != block.begin() - 1; ib--) { | ||
| if (ib->getKind() == clang::CFGElement::Statement) { | ||
| for (const auto& Element : llvm::reverse(block)) { |
There was a problem hiding this comment.
warning: no header providing "llvm::reverse" is directly included [misc-include-cleaner]
lib/Differentiator/UsefulAnalyzer.cpp:1:
+ #include <llvm/ADT/STLExtras.h>| if (ib->getKind() == clang::CFGElement::Statement) { | ||
| for (const auto& Element : llvm::reverse(block)) { | ||
| if (Element.getKind() == clang::CFGElement::Statement) { | ||
| const clang::Stmt* S = Element.castAs<clang::CFGStmt>().getStmt(); |
There was a problem hiding this comment.
warning: no header providing "clang::Stmt" is directly included [misc-include-cleaner]
lib/Differentiator/UsefulAnalyzer.cpp:1:
+ #include <clang/AST/Stmt.h>
Vedant2005goyal
force-pushed
the
issue-1074
branch
2 times, most recently
from
4411956 to
01f3196
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Vedant2005goyal
force-pushed
the
issue-1074
branch
from
01f3196 to
ce3dc19
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Vedant2005goyal
force-pushed
the
issue-1074
branch
from
ce3dc19 to
e074f79
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Vedant2005goyal
force-pushed
the
issue-1074
branch
from
e074f79 to
593a699
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Vedant2005goyal
force-pushed
the
issue-1074
branch
2 times, most recently
from
0faa242 to
50b23e4
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
| if (auto* IL = | ||
| dyn_cast<IntegerLiteral>(Init->IgnoreParenImpCasts())) { | ||
| if (IL->getValue() == 0) | ||
| VD->setInit(getZeroInit(VD->getType())); |
There was a problem hiding this comment.
Shouldn't this happen in DSClone when building the declaration statement?
There was a problem hiding this comment.
Thanks for the review!
That makes sense handling the getZeroInit during the declaration is cleaner and more efficient way than patching in the later stages.
I will make the changes accordingly and push the update.
|
clang-tidy review says "All clean, LGTM! 👍" |
…or assignments and initializations of variables Fixes vgvassilev#1074
vgvassilev
force-pushed
the
issue-1074
branch
from
b4cbb53 to
bb9d2f3
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
I have configured the clad both reverse mode and the forward mode to use 'getZeroInit()' for initialization and assignments of variable. I have changed the test suite to align with the changes made. While running the tests locally with ASAN enabled i encountered use-after-poison crash in clad/lib/Analyses/UsefulAnalyzer.cpp. And the fix of that problem (in the UsefulAnalyzer.cpp) is also made in this PR.
Below is the stack trace of the crash which has been resolved:-