Eliminates the reverse_forw pass generation when the custom pullback exists #1810
Merged
vgvassilev merged 1 commit intovgvassilev:masterfrom Apr 4, 2026
Merged
Eliminates the reverse_forw pass generation when the custom pullback exists #1810vgvassilev merged 1 commit intovgvassilev:masterfrom
vgvassilev merged 1 commit intovgvassilev:masterfrom
Conversation
…it removes unwanted tape overhead Fixes issue-1808
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
guitargeek
approved these changes
Apr 4, 2026
Collaborator
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much, excellent! This is an important optimization and gives me exactly results I was expecting: fast gradients without tracker/tape operations if the neural net operators have custom pullbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the generation of
reverse_mode_forward_passwhen a custom pullback is defined and this prevents unwanted tape overhead .Fixes #1808