Skip to content

Firecracker v1.4.1 vhive integration #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: firecracker-v1.4.1-vhive-integration
Choose a base branch
from
Open

Firecracker v1.4.1 vhive integration #43

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fad2f75
Add memory backend for CreateVMRequest
char-1ee Oct 9, 2023
3346214
Update memory backend in runtime service
char-1ee Oct 9, 2023
d0ef8a3
Fix typo
char-1ee Oct 12, 2023
49cac5e
Fix mismatch LoadSnapshot parameters
char-1ee Oct 18, 2023
6cc7736
Fix exclusion of memory backend
char-1ee Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions runtime/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,11 +590,19 @@ func (s *service) createVM(requestCtx context.Context, request *proto.CreateVMRe
opts = append(opts, jailedOpts...)

if request.LoadSnapshot {
if request.SnapshotPath == "" || request.MemFilePath == "" || request.ContainerSnapshotPath == "" {
return errors.New("failed to load snapshot: one of the snapshot loading parameters was not provided")
if request.SnapshotPath == "" || request.ContainerSnapshotPath == "" {
return errors.New("failed to load snapshot: snapshot path or container snapshot path was not provided")
}
if request.MemFilePath == "" && request.MemBackend.BackendType != "Uffd" {
return errors.New("failed to load snapshot: memroy file path was not provided")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
return errors.New("failed to load snapshot: memroy file path was not provided")
return errors.New("failed to load snapshot: memory file path was not provided")

}
opts = append(opts, firecracker.WithSnapshot(request.MemFilePath, request.SnapshotPath, request.ContainerSnapshotPath,
func(c *firecracker.SnapshotConfig) { c.ResumeVM = true }))

opts = append(opts,
firecracker.WithSnapshot(
request.MemFilePath,
request.SnapshotPath,
firecracker.WithMemoryBackend(request.MemBackend.BackendType, request.MemBackend.BackendPath),
func(c *firecracker.SnapshotConfig) { c.ResumeVM = true }))
}

// In the event that a noop jailer is used, we will pass in the shim context
Expand Down