Tweaked invoker and added tests by aryans1204 · Pull Request #540 · vhive-serverless/invitro

aryans1204 · 2024-10-30T14:01:08Z

Summary

A small summary of the requirements (in one/two sentences).

Implementation Notes ⚒️

Briefly outline the overall technical solution. If necessary, identify talking points where the reviewer's attention should be drawn to.

External Dependencies 🍀

Breaking API Changes ⚠️

Simply specify none (N/A) if not applicable.

pkg/driver/clients/grpc_client.go

pkg/driver/clients/grpc_client_test.go

pkg/driver/clients/vhivemetadata.go

pkg/driver/clients/grpc_client_test.go

leokondrashov · 2024-10-31T06:42:41Z

I don't see the tests for the driver/clients actually running in the CI. Can you please check the workflow?

Also, there is a linter error, please fix.

leokondrashov · 2024-11-08T08:41:41Z

Please squash your commits, sign off, and rebase the branch on current main.

pkg/driver/clients/invoker.go

aryans1204 · 2024-11-13T16:39:29Z

Hi, I've rebased on main and squashed and signed off my commits. I've also fixed the Dirigent mode to Knative mode. Please check

leokondrashov

Please rebase and fix the indentation in pkg/driver/clients/grpc_client.go

server/trace-func-go/trace_func.go

leokondrashov

Please fix the failing linter test and look at the comment about test VSwarm server once again.

pkg/driver/clients/grpc_client.go

pkg/driver/clients/grpc_client_test.go

server/trace-func-go/trace_func.go

pkg/driver/clients/grpc_client.go

pkg/workload/standard/workload.go

pkg/driver/clients/grpc_vswarm_client.go

pkg/driver/clients/grpc_client_test.go

leokondrashov

Please fix minor things

@cvetkovic when Aryan does, please take a look as well

pkg/driver/clients/grpc_client_test.go

pkg/driver/clients/grpc_vswarm_client.go

cvetkovic · 2025-01-08T11:29:37Z

pkg/driver/clients/vhivemetadata.go

+type vHiveMetadata struct {
+	WorkflowId   string    `json:"WorkflowId"`
+	InvocationId string    `json:"InvocationId"`
+	InvokedOn    time.Time `json:"InvokedOn"`
+}


I guess there is a copy of this structure somewhere in the vSwarm repo. Can you import it directly from there so we avoid duplicating structures and maintain consistency?

Yes, this is the same file, hut importing it from vSwarm directly had some issues with the go.mod file since this isn't directly declared as a package under the vSwarm repo

I would give this another try?

cvetkovic · 2025-01-08T11:41:54Z

pkg/driver/clients/grpc_vswarm_client.go

+type grpcVSwarmInvoker struct {
+	cfg *config.LoaderConfiguration
+}
+
+func newGRPCVSwarmInvoker(cfg *config.LoaderConfiguration) *grpcVSwarmInvoker {
+	return &grpcVSwarmInvoker{
+		cfg: cfg,
+	}
+}


There is a lot of core repetition between this and the regular gRPC invoker. Consider extracting the common code and putting interface for the different part of the code. Same for the changes to pkg/driver/clients/invoker.go.

I had done that before, with both invokers essentially integrated into the same function switched by the flag, but @leokondrashov had asked me to create two separate files for two different invokers, or maybe I am misunderstanding something

There is no contradiction. IIRC, I asked you to separate the two because you confusingly intermixed them. The proper way would be to make a general gRPC invoker call the actual gRPC with the correct protobuf (which you need to abstract away). Differences exist only in the Invoke function, which creates the protobuf and extracts the results. So, you need to make a gRPC client that uses the interface to make an actual call and extract the instance name, memory consumption, and actual duration.

I apologize if I caused confusion.

Hi @cvetkovic @leokondrashov I have addressed your comments earlier and integrated the two invokers by extracting the common code and using an interface to execute the different RPCs. Please let me know if you have any other thoughts.

Signed-off-by: aryans1204 <arshar1204@gmail.com> Add VHIVE_REPO and LOADER_REPO to setup script config Signed-off-by: Mohsen Ghasemi <mohsenghasemi8156@gmail.com> Added tests and created new vSwarm invoker Fixed linting Fixed VSwarm Invoker for Knative mode Committer: aryans1204 arshar1204@gmail.com Fixed VSwarm Invoker for Knative mode Added new invoker for vSwarm functions and added tests Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixed formatting under grpc_client.go Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixed driver tests Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixed linting and slimmed VSwarm tests Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixed linting errors Signed-off-by: aryans1204 <arshar1204@gmail.com> Removed redundancies from Workload Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixed vSwarm tests Signed-off-by: aryans1204 <arshar1204@gmail.com> Integrated vSwarm invoker into interface Signed-off-by: aryans1204 <arshar1204@gmail.com>

leokondrashov reviewed Oct 31, 2024

View reviewed changes

aryans1204 requested a review from leokondrashov November 7, 2024 10:32

leokondrashov reviewed Nov 8, 2024

View reviewed changes

pkg/driver/clients/invoker.go Outdated Show resolved Hide resolved

aryans1204 force-pushed the new-vswarm-invoker branch 2 times, most recently from 39cdf02 to 4c372fb Compare November 13, 2024 16:38

aryans1204 requested a review from leokondrashov November 13, 2024 16:39

leokondrashov reviewed Nov 15, 2024

View reviewed changes

server/trace-func-go/trace_func.go Outdated Show resolved Hide resolved

aryans1204 force-pushed the new-vswarm-invoker branch 2 times, most recently from 197fbbc to af79127 Compare November 30, 2024 01:51

aryans1204 requested a review from leokondrashov November 30, 2024 01:52

aryans1204 force-pushed the new-vswarm-invoker branch from af79127 to df997aa Compare December 1, 2024 10:58

leokondrashov reviewed Dec 4, 2024

View reviewed changes

pkg/driver/clients/grpc_client.go Show resolved Hide resolved

pkg/driver/clients/grpc_client_test.go Outdated Show resolved Hide resolved

server/trace-func-go/trace_func.go Outdated Show resolved Hide resolved

aryans1204 force-pushed the new-vswarm-invoker branch 3 times, most recently from c447b94 to 46a4c3b Compare December 13, 2024 12:19

aryans1204 requested a review from leokondrashov December 13, 2024 12:21

aryans1204 force-pushed the new-vswarm-invoker branch from 46a4c3b to f3b274d Compare December 24, 2024 05:32

leokondrashov reviewed Jan 2, 2025

View reviewed changes

pkg/driver/clients/grpc_client.go Show resolved Hide resolved

pkg/workload/standard/workload.go Outdated Show resolved Hide resolved

pkg/driver/clients/grpc_vswarm_client.go Outdated Show resolved Hide resolved

pkg/driver/clients/grpc_client_test.go Outdated Show resolved Hide resolved

aryans1204 force-pushed the new-vswarm-invoker branch from f3b274d to cdd2a17 Compare January 3, 2025 09:53

aryans1204 requested a review from leokondrashov January 3, 2025 10:05

leokondrashov reviewed Jan 6, 2025

View reviewed changes

pkg/driver/clients/grpc_client_test.go Outdated Show resolved Hide resolved

pkg/driver/clients/grpc_vswarm_client.go Outdated Show resolved Hide resolved

cvetkovic requested changes Jan 8, 2025

View reviewed changes

aryans1204 force-pushed the new-vswarm-invoker branch from cdd2a17 to 547100d Compare January 9, 2025 10:09

aryans1204 force-pushed the new-vswarm-invoker branch 2 times, most recently from 7e8e9e1 to 4733475 Compare January 20, 2025 13:49

aryans1204 requested review from cvetkovic and leokondrashov January 20, 2025 14:12

cvetkovic approved these changes Jan 20, 2025

View reviewed changes

leokondrashov approved these changes Jan 21, 2025

View reviewed changes

aryans1204 force-pushed the new-vswarm-invoker branch from 4733475 to dcc6d15 Compare January 22, 2025 08:55

aryans1204 merged commit eaa1d2d into main Jan 22, 2025
14 checks passed

aryans1204 deleted the new-vswarm-invoker branch January 22, 2025 09:04

Conversation

aryans1204 commented Oct 30, 2024

Summary

Implementation Notes ⚒️

External Dependencies 🍀

Breaking API Changes ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leokondrashov commented Oct 31, 2024

Uh oh!

leokondrashov commented Nov 8, 2024

Uh oh!

Uh oh!

aryans1204 commented Nov 13, 2024

Uh oh!

leokondrashov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

leokondrashov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leokondrashov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants