Added RPS support for dirigent-dandelion-workflows by tostocker · Pull Request #605 · vhive-serverless/invitro

tostocker · 2025-02-12T09:47:26Z

Summary

Adds RPS support for dirigent-dandelion-workflows.

Implementation Notes ⚒️

We have extended the dirigent cluster manager to be able to orchestrate workflows and want to benchmark it in order to further optimize it. So orchestration is done within dirigent and the workflows are to be provided when registering them in the system. From outside the system registering workflows is different to registering a single function but invoking either one looks the same to the user.
The workflow description is exported as a file that is read and the content is given to dirigent in the registration. The structure is not platform specific (though only works on dirigent) but as already said the orchestration inside dirigent only supports the dandelion platform.
In this PR we extend the dirigent deployer and HTTP client to be able to also handle workflow requests beside the function requests it already can. This requires a few more configuration parameters.
Moves dirigent specific configuration parameters into separate dirigent config file that is loaded only when the platform is Dirigent. This also affects the backend which is now a dirigent config parameter and no longer a separate platform.
Adapts the changes from PR #606.

External Dependencies 🍀

none

Breaking API Changes ⚠️

none

cmd/loader.go

pkg/driver/clients/invoker.go

pkg/driver/deployment/dirigent.go

cvetkovic

Looks good. Just some minor comments above.

leokondrashov

Overall comment, can you add tests for the deployment? I don't know how hard it is to test the dirigent and dandelion setup in github actions, but better to have them.

pkg/driver/clients/http_client.go

cmd/config_dirigent_dandelion_rps.json

cmd/loader.go

docs/configuration.md

pkg/config/parser.go

pkg/driver/clients/dandelion_interface.go

pkg/driver/clients/http_client.go

pkg/driver/deployment/deployer.go

pkg/driver/clients/invoker.go

cvetkovic

LGTM! Just a small bugfix is needed. If @leokondrashov agrees, we can merge.

cmd/loader.go

leokondrashov

Looks good, please fix the docs and couple of options

docs/configuration.md

pkg/generator/rps.go

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Signed-off-by: Tobias Stocker <stocker@student.ethz.ch>

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

tostocker force-pushed the dirigent_workflow_rps_support branch 3 times, most recently from 7ecf636 to aa3d6dd Compare February 12, 2025 09:55

tostocker requested a review from cvetkovic February 12, 2025 10:45

tostocker added the enhancement New feature or request label Feb 12, 2025

cvetkovic approved these changes Feb 12, 2025

View reviewed changes

cmd/loader.go Outdated Show resolved Hide resolved

pkg/driver/clients/invoker.go Outdated Show resolved Hide resolved

pkg/driver/deployment/dirigent.go Outdated Show resolved Hide resolved

cvetkovic requested changes Feb 12, 2025

View reviewed changes

tostocker requested a review from leokondrashov February 12, 2025 13:55

tostocker force-pushed the dirigent_workflow_rps_support branch from 1f8096c to d1f3f57 Compare February 12, 2025 13:58

leokondrashov reviewed Feb 14, 2025

View reviewed changes

pkg/driver/clients/http_client.go Outdated Show resolved Hide resolved

cvetkovic linked an issue Feb 14, 2025 that may be closed by this pull request

Dirigent config as a separate JSON #520

Closed

tostocker force-pushed the dirigent_workflow_rps_support branch 6 times, most recently from 0c7392e to 49628dc Compare February 18, 2025 14:27

tostocker requested review from cvetkovic and leokondrashov February 18, 2025 14:36

cvetkovic requested changes Feb 20, 2025

View reviewed changes

tostocker force-pushed the dirigent_workflow_rps_support branch from da08719 to 30dd4da Compare February 24, 2025 16:15

cvetkovic reviewed Feb 25, 2025

View reviewed changes

cmd/loader.go Show resolved Hide resolved

leokondrashov reviewed Feb 26, 2025

View reviewed changes

docs/configuration.md Show resolved Hide resolved

docs/configuration.md Outdated Show resolved Hide resolved

docs/configuration.md Outdated Show resolved Hide resolved

leokondrashov reviewed Feb 27, 2025

View reviewed changes

pkg/generator/rps.go Show resolved Hide resolved

cvetkovic previously approved these changes Feb 27, 2025

View reviewed changes

tostocker force-pushed the dirigent_workflow_rps_support branch from 73b3de6 to 465937a Compare February 28, 2025 13:28

tostocker dismissed cvetkovic’s stale review via df944db February 28, 2025 14:06

cvetkovic previously approved these changes Feb 28, 2025

View reviewed changes

tostocker dismissed cvetkovic’s stale review via 20c8037 March 3, 2025 07:47

cvetkovic previously approved these changes Mar 3, 2025

View reviewed changes

tostocker added 14 commits March 5, 2025 16:33

Added RPS support for dirigent-dandelion-workflows

cf8e625

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Changes as suggested in the pr.

ef34a07

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Moved dirigent specific params into separate config, HTTP client cleanup

d3d3a03

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Added changes from lsimic (gpu rps payload), docs update

7e21dfa

Signed-off-by: Tobias Stocker <stocker@student.ethz.ch>

Fixed docs spellcheck

9ca54a0

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Small bugfix

cc3dd50

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Changes as requested in the PR

1cfcfae

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Extended wordlist

a318bb4

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Added platform and backend constants

b54054a

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Small bugfix

d19fd1e

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Moved RpsImage and PrepullMode into dirigent config.

18abcef

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Dirigent metadata bugfix.

f2f4fd7

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Fixed link

419f74a

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

Fixed wordlist

2b5d98e

Signed-off-by: Tobias Stocker <tstocker@student.ethz.ch>

tostocker dismissed cvetkovic’s stale review via 2b5d98e March 5, 2025 15:35

tostocker force-pushed the dirigent_workflow_rps_support branch from 5241fd3 to 2b5d98e Compare March 5, 2025 15:35

cvetkovic approved these changes Mar 6, 2025

View reviewed changes

tostocker merged commit 5a4f00d into main Mar 6, 2025
15 checks passed

tostocker deleted the dirigent_workflow_rps_support branch March 6, 2025 15:01

Conversation

tostocker commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Implementation Notes ⚒️

External Dependencies 🍀

Breaking API Changes ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cvetkovic left a comment

Choose a reason for hiding this comment

Uh oh!

leokondrashov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cvetkovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

leokondrashov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tostocker commented Feb 12, 2025 •

edited

Loading