Fix -> Invoke both trace-func and vSwarm functions in the same run #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvetkovic
reviewed
Mar 31, 2025
pkg/driver/trace_driver.go
Outdated
|
|
||
| func (d *Driver) generateInvokers() { | ||
| for _, function := range d.Configuration.Functions { | ||
| trace_func := strings.Contains(function.Name, "trace-func") |
Contributor
There was a problem hiding this comment.
I wouldn't rely on function name here. In RPS mode, we have functions named differently even for the trace functions. BTW, we would need to think how to pass this mapping in that case as well.
Contributor
|
@aryans1204 are there any updates on this? |
leokondrashov
force-pushed
the
fix-invoker-client
branch
2 times, most recently
from
75411f3 to
9330bd6
Compare
Signed-off-by: aryans1204 <[email protected]>
Signed-off-by: aryans1204 <[email protected]>
Minor fixes Signed-off-by: Leonid Kondrashov <[email protected]>
leokondrashov
force-pushed
the
fix-invoker-client
branch
from
9330bd6 to
671bb5d
Compare
leokondrashov
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small summary of the requirements (in one/two sentences).
This is a fix for allowing Loader to invoke both trace-func and vSwarm functions in the same run.
Implementation Notes ⚒️
The
Invokerinterface is moved to pkgcommonand the Invoker interface is removed from the driver config and instead moved to thecommon.Function. Similarly, therecord.gofile containing theExecutionRecordis moved tocommon, to allow for the ExecutionRecord to be used in the Invoke interface call, which would not be possible otherwise since themetricpackage cant be imported incommondue to cyclic dependency. Most other files are changed to reflect this change of package frommetrictocommon. Thetrace_driver.gois changed to generate clients for each parsed function based onExecuteorSayHelloand theinvokeFunctionis changed to invoke the function specific client. No significant changes are made to theInvokerclient, and no chnages are made to the deployment stages. For the trace parsing, undermapper_trace_parser.gothe YAML file for trace-func is embedded if the chosen function is trace-func.External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.