Integrate Azure Functions deployment with In-Vitro#650
Merged
leokondrashov merged 1 commit intomainfrom Jun 4, 2025
Merged
Conversation
wanghanchengchn
force-pushed
the
kavi/azure
branch
from
958e6ca to
53be83f
Compare
wanghanchengchn
force-pushed
the
kavi/azure
branch
2 times, most recently
from
e03f007 to
947db1a
Compare
Contributor
leokondrashov
left a comment
leokondrashov
left a comment
There was a problem hiding this comment.
Looks good to me now.
@cvetkovic please take a look
cvetkovic
reviewed
Jun 2, 2025
| "AzureWebJobsFeatureFlags": "EnableWorkerIndexing", | ||
| "AzureWebJobsStorage": "" | ||
| } | ||
|
|
pkg/driver/clients/azure_client.go
Outdated
| } | ||
|
|
||
| func azureHttpInvocation(dataString string, function *common.Function, AnnounceDoneExe *sync.WaitGroup, tlsSkipVerify bool) (bool, *mc.ExecutionRecordBase, *http.Response, []byte) { | ||
| //defer AnnounceDoneExe.Done() |
Contributor
There was a problem hiding this comment.
Why is this unused, but passed and saved in the announceDoneExe?
pkg/driver/clients/azure_client.go
Outdated
| record.StartTime = start.UnixMicro() | ||
| record.Instance = function.Name | ||
| requestURL := function.Endpoint | ||
| if tlsSkipVerify { |
Contributor
There was a problem hiding this comment.
This is a hardcoded false in the caller function.
wanghanchengchn
force-pushed
the
kavi/azure
branch
2 times, most recently
from
8f812c8 to
901c111
Compare
Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com> Integrate Azure Functions deployment Signed-off-by: hancheng wang <wanghanchengchn@gmail.com>
wanghanchengchn
force-pushed
the
kavi/azure
branch
from
901c111 to
aff9bee
Compare
leokondrashov
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small summary of the requirements (in one/two sentences).
To integrate Azure Functions deployment with In-Vitro. This feature enables deployment of serverless functions on the Azure Functions platform. Previous commits and discussions can be found in PR 569.
Implementation Notes ⚒️
This PR adds a workflow to deploy multiple functions to Azure Functions via ZIP deployment.
Documentation on the steps to deploy the functions to Azure are included in
loader.md.azurefunctions_setup: this folder contains the relevant config and workload files to be used for deployment.azure_functions.go: initializes Azure resources required for deployment to Azure Functions, such as Resource Group, Storage Account, and Function App. In order to deploy multiple functions via ZIP, each function must have its own specific folder containing required dependencies, before zipping and deploying all the function folders as a single package. After successful deployment, local temporary folders holding the functions and the zip package are cleaned up.(Note: All cleanup, including local temporary folders, will be done after entire experiment is completed.)
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.