Skip to content

New rebase of pyinstaller branch with fixes and updated modules - #304

Open
edevil wants to merge 10 commits into
vial-kb:mainfrom
edevil:pyinstaller-rebase3
Open

New rebase of pyinstaller branch with fixes and updated modules#304
edevil wants to merge 10 commits into
vial-kb:mainfrom
edevil:pyinstaller-rebase3

Conversation

@edevil

@edevil edevil commented Feb 23, 2025

Copy link
Copy Markdown

Based on #238 I corrected the build script, updated modules and tested the generated artifacts on Mac, Linux and Windows. They all seemed to start up correctly.

cc @xyzz

xyzz and others added 9 commits February 20, 2025 14:55
fbs was holding back the code from using modern versions of python, qt,
and everything else. Remove fsb and update everything.

 * Remove fbs from spec
 * update to python 3.12
 * update all dependencies to latest minor releases
 * update to latest version of pyinstaller
 * re-implement part of fbs context object to minimize refactoring
 * update Vial.spec to have all options necessary to run
@xyzz

xyzz commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

from some quick testing it fails at least on ubuntu 22.04 and debian 12. the web release needs to be tested as well to make sure it still builds

Commited fixes suggested in original PR, namely:
- Updated dependencies to make this work on current MacOS.
- Added call to freeze_support() as mentioned in
https://pyinstaller.org/en/stable/common-issues-and-pitfalls.html#multi-processing
- Added missing backslash in comment
@edevil
edevil force-pushed the pyinstaller-rebase3 branch from 3f0420b to 048a8cd Compare February 23, 2025 20:22
@edevil

edevil commented Feb 23, 2025

Copy link
Copy Markdown
Author

It should be just a matter of building the linux version in an older distro. I just changed it to build on ubuntu 22.04. Unfortunately I don't have an easy way to test on that version.

As for the web version, how can I test it? The CI doesn't seem to test it.

@edevil

edevil commented Feb 23, 2025

Copy link
Copy Markdown
Author

I span up a ubuntu 22.04 VM and the latest version starts up. Can you point me to the web version?

@edevil

edevil commented Mar 2, 2025

Copy link
Copy Markdown
Author

Hey @xyzz , can you tell me how I can test the web version, please?

@xyzz

xyzz commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

there's a description in the readme here - https://github.com/vial-kb/vial-web

@edevil

edevil commented Mar 8, 2025

Copy link
Copy Markdown
Author

@xyzz build seems to have succeeded

 ~/work/vc/vial-web/src  main  ls -l build                                                                                            ✔  41s
total 32192
-rw-rw-r-- 1 andre andre    24456 mar  8 16:44 icon.png
-rw-rw-r-- 1 andre andre     6963 mar  8 16:44 index.html
-rw-rw-r-- 1 andre andre  9160057 mar  8 16:44 main-afd00abb2f3ced6bfdc03855d49d107bdd5e78b2bd1af601b3f90f0fead192a9.data
-rw-rw-r-- 1 andre andre   345518 mar  8 16:44 main-afd00abb2f3ced6bfdc03855d49d107bdd5e78b2bd1af601b3f90f0fead192a9.js
-rwxrwxr-x 1 andre andre 23414237 mar  8 16:44 main-afd00abb2f3ced6bfdc03855d49d107bdd5e78b2bd1af601b3f90f0fead192a9.wasm*
-rw-rw-r-- 1 andre andre     3804 mar  8 16:44 main-afd00abb2f3ced6bfdc03855d49d107bdd5e78b2bd1af601b3f90f0fead192a9.worker.js

@xyzz

xyzz commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

seems that fresh windows install flags it as a trojan :/
image
image
as a result it's impossible to install or run. for some reason that's not the case with recent actions e.g. https://github.com/vial-kb/vial-gui/actions/runs/13652942538

@edevil

edevil commented Mar 8, 2025

Copy link
Copy Markdown
Author

Seems like a known issue. pyinstaller/pyinstaller#5854

Oh well, I tried.

@xyzz

xyzz commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

from what i could gather searching online the possible ways forward are:

  • pay for a code signing certificate
  • use a different (older) pyinstaller version in hopes that the bootloader is allowlisted by ms defender (however, from checking virustotal the bootloader itself doesn't hit as many detections as vial.exe for some reason)
  • compile our own pyinstaller bootloader and maybe if it's sufficiently different it won't be flagged (but this doesn't entirely make sense to me based off prior allowlist discussion)
  • submit updated vial.exe to ms every time we build a release so that defender allowlists it specifically

@edevil

edevil commented Mar 9, 2025

Copy link
Copy Markdown
Author

There's also Nuitka.

@LukeDRussell

LukeDRussell commented Mar 23, 2025

Copy link
Copy Markdown

It runs OK on my Windows PC, two weeks later. I'm running up to date Windows 11 Pro 24H2 with build 26100.3476.

@kbladewht

Copy link
Copy Markdown

this change looks good for me

@xyzz

xyzz commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

after checking a lot of combinations, it seems to be OK for Python 3.11 with Pyinstaller 5.13.2 in https://github.com/vial-kb/vial-gui/tree/pyinstaller-2025-08-18, however there are still issues such as there is no app icon on windows anymore
2025-08-18_19-19

@JkktBkkt

JkktBkkt commented Apr 6, 2026

Copy link
Copy Markdown

using python 3.14 ran into
ERROR: Could not find a version that satisfies the requirement pyinstaller==6.12.0 (from versions: 2.0, 2.1, 3.0, 3.1, 3.1.1, 3.2, 3.2.1, 3.3, 3.3.1, 3.4, 3.5, 3.6, 4.0, 4.1, 4.2, 4.3, 4.4, 4.5, 4.5.1, 6.15.0, 6.16.0, 6.17.0, 6.18.0, 6.19.0)
solved by using 3.11 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants