App 15105 create entity relationships #379
Conversation
🦋 Changeset detectedLatest commit: 5c46a77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattmacf98
requested review from
DTCurrie and
micheal-parks
and removed request for
DTCurrie and
micheal-parks
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| const y = positions[i + 1] / 1000 | ||
| const z = positions[i + 2] / 1000 | ||
|
|
||
| const distance = point.distanceToSquared(new Vector3(x, y, z)) |
There was a problem hiding this comment.
should use a pooled vector
| const distance = point.distanceToSquared(new Vector3(x, y, z)) | |
| const distance = point.distanceToSquared(vec3.set(x, y, z)) |
| y: number | ||
| z: number | ||
| } | ||
| orientation?: { |
There was a problem hiding this comment.
| orientation?: { | |
| direction?: { |
since this isn't a true orientation
| y: 0, // World position Y in meters | ||
| z: 0, // World position Z in meters | ||
| }) | ||
| export const Hover = trait(() => ({ |
There was a problem hiding this comment.
I'd maybe call this trait "InstancedPose" instead, since that's what it represents (an arrow instance, a point instance within THREE.Points, other instance types in the future?). Memory layout could also be made more efficient (struct of arrays):
export const InstancedPose = trait({
x: 0, y: 0, z: 0, ox: 0, oY: 0, oZ: 1, theta: 0, index: -1
})
There was a problem hiding this comment.
ok yeah i can update that
| provideFramelessComponents() | ||
|
|
||
| const { focus } = provideSelection() | ||
| provideHoveredLinkedEntities() |
There was a problem hiding this comment.
Maybe leave hovered out of the naming for all of the new introductions that involve linking?
provideLinkedEntities()
While it's true that right now that linking is visually represented only during hovering, it's totally possible in the near future this might change or other types visual feedback for linking could be introduced
There was a problem hiding this comment.
ok yeah I can remove the hovered naming for this relationship context
| import { Parser } from 'expr-eval' | ||
| import { useTrait } from '$lib/ecs' | ||
|
|
||
| const parser = new Parser() |
There was a problem hiding this comment.
can probably move this to a <script module> section to avoid new parsers per entity
|
|
||
| const displayedHoverInfo = useTrait(() => displayEntity, traits.Hover) | ||
|
|
||
| let hoverInfo: HoverInfo | null = $state.raw(null) |
There was a problem hiding this comment.
| let hoverInfo: HoverInfo | null = $state.raw(null) | |
| let hoverInfo= $state.raw<HoverInfo | null>(null) |
just slightly more typesafe :)
2 participants
Description
This PR creates the first koota relationship for our entities and creates a hover link entity which enables directional index mapping for hover actions.
Testing
Screen.Recording.2026-02-09.at.2.mp4