Start cleaning up type annotations #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penguinland
commented
Feb 11, 2025
| max_value=1e5, | ||
| default_value=1e3, | ||
| max_value=100000, | ||
| default_value=1000, |
Contributor
Author
There was a problem hiding this comment.
This surprised me, but 1e5 is a float, not an int!
bhaney
approved these changes
Feb 14, 2025
Collaborator
There was a problem hiding this comment.
This look good! an optional change: if Image.Image is used anywhere else in the python image.py file, I'd prefer from PIL.Image import Image to be used, so that the type annotation can just be Image. but if the type annotation is the only place it shows up, you can leave it as it is
I see we use Image.Open in this file, it's all right to keep the annotation Image.Image
Contributor
Author
|
Rebased to fix merge conflicts. Will take one last look and then merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started looking at this due to the obvious errors in the type annotations mentioned in #23.
When I started this branch, running
mypy main.pygave 150ish errors. Between this PR and viamrobotics/viam-python-sdk#846, it's down to 100ish errors. So, there's more to do, but this is at least a start. When there are no errors, we should add another CI check that running mypy (or any other type checker, if you want something else) has no errors.