[APP-7099] [APP-7209] Integrate subsystems and use new configuration proto/format#59
[APP-7099] [APP-7209] Integrate subsystems and use new configuration proto/format#59Otterverse merged 13 commits intomainfrom
Conversation
There was a problem hiding this comment.
This was mostly just part of the rename from provsioning>networking... not sure why it decided ONLY this file was new. Practically zero actual changes in this file.
There was a problem hiding this comment.
This file is new, and centralizes ALL config processing and validation, including from viam-defaults.json, cloud, and CLI args.
There was a problem hiding this comment.
This is for handling the old "viam-provisioning.json" for backwards compatibility.
There was a problem hiding this comment.
Another large chunk of what's important. This centralizes (and simplifies) all the version tracking and binary update code in one object.
| } | ||
| } | ||
|
|
||
| if shouldReboot && w.doReboot(ctx) { |
There was a problem hiding this comment.
This and below are a few changes for the reboot functionality. Everything else in this file is just renames of fields/structs/etc.
There was a problem hiding this comment.
ALMOST everything in this file is just renames. The exception is reboot handling (noted with comment) near the bottom.
There was a problem hiding this comment.
This file was moved with (almost) zero changes (just renames) but github doesn't recognize it properly.
There was a problem hiding this comment.
This used to background a go routine. Has been simplified to run the (very simple) functions as part of Start() itself.
…iew" This reverts commit 1961e81.
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
3 participants
I believe this is ready for final review/QA.
RC2 binaries are built and published for testing. See document below.
https://docs.google.com/document/d/12rDyo3tPkxUllVc-IQ9SzqiqEAzd2mSuUBxkG11Kq-s/