Skip to content

APP-7128 support agent on windows#72

Merged
abe-winter merged 26 commits intomainfrom
aw-windows-rebase
Mar 13, 2025
Merged

APP-7128 support agent on windows#72
abe-winter merged 26 commits intomainfrom
aw-windows-rebase

Conversation

@abe-winter
Copy link
Member

@abe-winter abe-winter commented Feb 21, 2025

What changed

  • installer support
    • old agent.bat (can ditch this at some point)
    • YML workflow to build msi
    • .wxs file for MSI
  • utils
    • config.go: add two Disabled() getters to always disable some subsystems on windows (regardless of config)
    • utils.go: path setup, factor our checkPathOwner, auto-add .exe extension, fix some file handling errors, do netsh
    • make Kill and SyncFS platform-dependent
    • add KillTree
  • main.go
    • factor out big chunks that don't work on win yet: runPlatformProvisioning, waitOnline
    • add main_windows.go which manages a windows service

Why

Support agent on windows

Manual testing

  • on windows:
    • test start / stop (including RDK module processes)
    • test upgrading RDK + agent
  • test to make sure linux hasn't been broken

@abe-winter abe-winter requested a review from ale7714 March 11, 2025 00:50
@abe-winter abe-winter marked this pull request as ready for review March 11, 2025 00:58
Copy link
Member

@ale7714 ale7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense to me. After you merge, i'd like to test latest on linux to make sure is all 👍

Copy link
Contributor

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor stuff, and a few questions. I'm not up to speed on windows here, so apologies for any dumb callouts/questions there.

Copy link
Contributor

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes since last review all look fine (no NEW issues) and I trust you on the ticket-vs-resolve-now stuff. Good to merge here, but let's do some testing on the dev version that gets built from this before actually releasing as stable.

@abe-winter abe-winter changed the title support agent on windows APP-7128 support agent on windows Mar 13, 2025
@abe-winter abe-winter merged commit a340a78 into main Mar 13, 2025
3 checks passed
@abe-winter abe-winter deleted the aw-windows-rebase branch March 13, 2025 01:40
@atlassian
Copy link

atlassian bot commented Sep 22, 2025

🔗 Link your GitHub account to Atlassian

To enable Code Reviewer, please link your GitHub account to your Atlassian account.

Click here to connect your accounts

This is a one-time setup that takes less than a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants