Conversation
…root/devmode, factor out WaitOnline, factor out SIGURG
… CheckPathOwner, win imp of SyncFS
… in viamserver.stop, skip healthcheck in win, restartallowed true
ale7714
left a comment
There was a problem hiding this comment.
Code change makes sense to me. After you merge, i'd like to test latest on linux to make sure is all 👍
Otterverse
left a comment
There was a problem hiding this comment.
Mostly minor stuff, and a few questions. I'm not up to speed on windows here, so apologies for any dumb callouts/questions there.
Otterverse
left a comment
There was a problem hiding this comment.
Changes since last review all look fine (no NEW issues) and I trust you on the ticket-vs-resolve-now stuff. Good to merge here, but let's do some testing on the dev version that gets built from this before actually releasing as stable.
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
What changed
Disabled()getters to always disable some subsystems on windows (regardless of config)Why
Support agent on windows
Manual testing