Add OpenTelemetry shim library #511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
Member
|
looks good, but adding some tests for OtelDevelopmentExporter would be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays some very minimal groundwork to start converting rdk from OpenCensus to OpenTelemetry for tracing. I'll open an rdk PR in parallel but this will have to get merged first so we can do a release + update the rdk go.mod.
tracewith a public API designed to facilitate migrating from OpenCensus to OpenTelemetry.OtelDevExporterstruct that does the same thing asdevExporter, print traces and metrics to stdout`, but with otel spans instead of OpenCensus. For now it still uses OpenCensus metrics but that could and probably should change in the future, I just don't want to add scope creep right now.