APP-8776 Move geometry proto conversions to reference frame #5149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
viambot
added
safe to test
raybjork
suggested changes
Jul 28, 2025
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
viambot
added
safe to test
raybjork
reviewed
Aug 12, 2025
Contributor
raybjork
left a comment
raybjork
left a comment
There was a problem hiding this comment.
Tests are failing but otherwise this seems good
Member
Author
I think the failures are from me pointing to my local version of the API, since the API changes PR hasn't been merged yet. I will run them on my local to verify, but assuming they pass we should be good. The next steps will be for me to double-check the SDKs to make sure the changes in API don't break anything there, then I will announce the breaking changes and merge everything to go out in the same release. |
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
viambot
added
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
…6-move-pointcloud-to-spatialmath
viambot
added
safe to test
Member
Author
|
@raybjork merged the API PR, all tests are passing with the actual changes. |
raybjork
approved these changes
Aug 28, 2025
danielbotros
pushed a commit
to danielbotros/rdk
that referenced
this pull request
Sep 8, 2025
danielbotros
pushed a commit
to danielbotros/rdk
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relocates the proto conversions for geometries and point clouds to the
referenceframepackage, based on the changes in this API PR.The reason for moving proto conversions to
referenceframewas driven by the inclusion of the point cloud as a geometry type. Thereferenceframepackage is already dependent on both thespatialmathandpointcloud, so it did not introduce any cyclical import issues to handle the conversion logic. After some discussion, although this is not the ideal long-term location for this code, it makes the most sense for now.API PR: viamrobotics/api#695
Scope doc: https://docs.google.com/document/d/1ionvyBa7x3HZU_rwDPBvrAUrQjBrP6sJ10Z_xbBTue8/edit?tab=t.0#heading=h.tcicyojyqi6c