Skip to content

Commit 6d097a6

Browse files
committed
Revert to for loop and add comment
1 parent 36babcc commit 6d097a6

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/viam/sdk/components/private/camera_client.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,13 @@ Camera::image_collection CameraClient::get_images(std::vector<std::string> filte
134134
.with(extra,
135135
[&](auto& request) {
136136
if (!filter_source_names.empty()) {
137-
request.mutable_filter_source_names()->Add(
138-
std::make_move_iterator(filter_source_names.begin()),
139-
std::make_move_iterator(filter_source_names.end()));
137+
// Once gRPC version is bumped we can avoid the loop and transfer ownership
138+
// of the vector to the request.
139+
// *request.mutable_filter_source_names() = std::move(filter_source_names)
140+
request.mutable_filter_source_names()->Reserve(filter_source_names.size());
141+
for (auto& source_name : filter_source_names) {
142+
request.add_filter_source_names(std::move(source_name));
143+
}
140144
}
141145
})
142146
.invoke([](auto& response) { return from_proto(response); });

0 commit comments

Comments
 (0)