File tree Expand file tree Collapse file tree 1 file changed +6
-7
lines changed
src/viam/sdk/components/private Expand file tree Collapse file tree 1 file changed +6
-7
lines changed Original file line number Diff line number Diff line change @@ -134,13 +134,12 @@ Camera::image_collection CameraClient::get_images(std::vector<std::string> filte
134134 .with (extra,
135135 [&](auto & request) {
136136 if (!filter_source_names.empty ()) {
137- // Once gRPC version is bumped we can avoid the loop and transfer ownership
138- // of the vector to the request.
139- // *request.mutable_filter_source_names() = std::move(filter_source_names)
140- request.mutable_filter_source_names ()->Reserve (filter_source_names.size ());
141- for (auto & source_name : filter_source_names) {
142- request.add_filter_source_names (std::move (source_name));
143- }
137+ // in newer gRPC versions we would be able to call `Add` or `Assign` on an
138+ // iterator range rather than element-wise copy
139+ request.mutable_filter_source_names ()->Reserve (filter_source_names.size ());
140+ for (auto & source_name : filter_source_names) {
141+ request.add_filter_source_names (std::move (source_name));
142+ }
144143 }
145144 })
146145 .invoke ([](auto & response) { return from_proto (response); });
You can’t perform that action at this time.
0 commit comments