Fix conan shared builds and conan CI RSDK-9113

.github/workflows/conan.yml

@@ -1,10 +1,14 @@
 name: Test conan packages
 
 on:
-  # Run weekdays at 11:15pm UTC, and specify below to only run if there's been new commits
+  # Run weekdays at 11:15pm UTC
   schedule:
     - cron: "15 11 * * 1-5"
   workflow_dispatch:
+  pull_request:
+    paths:
+      - conanfile.py
+      - test_package/conanfile.py
 
 jobs:
   prepare:
@@ -14,17 +18,6 @@ jobs:
       - name: Checkout Code
         uses: actions/checkout@v4
 
-      - name: Get new commit count
-        id: new_commit_count
-        shell: bash
-        run: echo "commit_count=$(git log --oneline --since '24 hours ago' | wc -l)" >> $GITHUB_OUTPUT
-
-      - name: Cancelling scheduled build with no new commits
-        uses: andymckay/[email protected]
-        if: |
-          steps.new_commit_count.outputs.commit_count == '0' &&
-          github.event_name == 'schedule'
-
   build_macos:
     if: github.repository_owner == 'viamrobotics'
     needs: [prepare]

conanfile.py

@@ -32,25 +32,20 @@ def set_version(self):
         self.version = re.search("set\(CMAKE_PROJECT_VERSION (.+)\)", content).group(1).strip()
 
     def configure(self):
-        # If we're building static then build the world as static, otherwise
-        # stuff will probably break.
-        # If you want your shared build to also build the world as shared, you
-        # can invoke conan with -o "&:shared=False" -o "*:shared=False",
-        # possibly with --build=missing or --build=cascade as desired,
-        # but this is probably not necessary.
-        if not self.options.shared:
-            self.options["*"].shared = False
+        # The shared-ness of grpc and protobuf needs to match our shared-ness or stuff will break
+        self.options["grpc"].shared = self.options.shared
+        self.options["protobuf"].shared = self.options.shared
 
     def requirements(self):
-        self.requires('boost/[>=1.74.0]', transitive_headers=True)
+        self.requires('boost/[>=1.74.0]', transitive_headers=True, transitive_libs=True)
 
         # The SDK supports older grpc and protobuf, but these are the oldest
         # maintained conan packages.
-        self.requires('grpc/[>=1.48.4]', transitive_headers=True)
-        self.requires('protobuf/[>=3.17.1]', transitive_headers=True)
+        self.requires('grpc/[>=1.48.4]', transitive_headers=True, transitive_libs=True)
+        self.requires('protobuf/[>=3.17.1]', transitive_headers=True, transitive_libs=True)
 
         self.requires('xtensor/[>=0.24.3]', transitive_headers=True)
-        self.requires('abseil/[>=20230125.3]')
+        self.requires('abseil/[>=20230125.3]', transitive_libs=True)
 
     def build_requirements(self):
         if self.options.offline_proto_generation:
@@ -89,7 +84,7 @@ def package_info(self):
         for component in ["viamsdk", "viamapi"]:
            self.cpp_info.components[component].set_property("cmake_target_name", "viam-cpp-sdk::{}".format(component))
            self.cpp_info.components[component].set_property("pkg_config_name", "viam-cpp-sdk-lib{}".format(component))
-           self.cpp_info.components[component].requires = ["grpc::grpc++", "protobuf::libprotobuf"]
+           self.cpp_info.components[component].requires = ["grpc::grpc++", "grpc::grpc++_reflection", "protobuf::libprotobuf"]
            if self.settings.os in ["Linux", "FreeBSD"]:
             self.cpp_info.components[component].system_libs = ["pthread"]
 
@@ -117,8 +112,7 @@ def package_info(self):
             "xtensor::xtensor",
 
             "viam_rust_utils",
-            "abseil::absl_strings",
-            "grpc::grpc++_reflection"
+            "abseil::absl_strings"
         ])
 
         self.cpp_info.components["viamsdk"].frameworks = ["Security"]