remove api imports from examples #347
Conversation
lia-viam
requested review from
purplenicole730 and
stuqdog
and removed request for
a team
| #include <grpcpp/grpcpp.h> | ||
| #include <grpcpp/support/status.h> | ||
|
|
||
| #include <viam/api/common/v1/common.pb.h> |
There was a problem hiding this comment.
⬆️ - Are the grpcpp headers still required in this file and others?
There was a problem hiding this comment.
In this particular file no! But while we're on the subject gizmo/api.hpp and summation/api.hpp both include grpcpp/channel.h. This could be replaced with the grpc_fwd.hpp file but I'm not sure if it's worth the effort, thoughts?
There was a problem hiding this comment.
Or rather, not that it takes much effort but that it's a little awkward and perhaps it's a non-goal for users to not have google imports in headers
There was a problem hiding this comment.
I wouldn't bother in the ones that are doing custom APIs, since in that case I think the user is up to something complex, but for cases where it is just using the standard C++ SDK API I'd drop out the grpc headers if possible I think. Otherwise they will get copied in endlessly.
There was a problem hiding this comment.
agreed, I don't think we should scrub files with custom APIs.
3 participants
Cherry-picked from #325