-
Notifications
You must be signed in to change notification settings - Fork 27
RSDK-9740: Make google libraries a private dependency of the SDK #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
cf3256a
7ece1c8
3f32c12
e9bbc32
d940b1a
1448de3
8fe505f
334b528
bac8c8a
92af179
bfe6e21
413e162
c88e685
3577cbc
c600fdd
f223455
c193784
cbcfd23
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ add_executable(simple_module | |
| target_link_libraries(simple_module | ||
| PRIVATE Threads::Threads | ||
| viam-cpp-sdk::viamsdk | ||
| ${VIAMCPPSDK_GRPCXX_LIBRARIES} | ||
|
||
| ) | ||
|
|
||
| install( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ if (VIAMCPPSDK_BUILD_TFLITE_EXAMPLE_MODULE) | |
| target_link_libraries(tflite_module | ||
| PRIVATE Threads::Threads | ||
| PRIVATE viam-cpp-sdk::viamsdk | ||
| PRIVATE ${VIAMCPPSDK_GRPCXX_LIBRARIES} | ||
|
||
| PRIVATE tensorflowlite_c | ||
| ) | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ find_package(Threads REQUIRED) | |
| # | ||
| find_package(viam-cpp-sdk CONFIG REQUIRED viamsdk) | ||
|
|
||
| find_package(gRPC CONFIG REQUIRED) | ||
|
||
|
|
||
|
|
||
| # Here we compile the `examle_dial.cpp` and `example_module.cpp` source | ||
| # files into executables, but as parts of separate projects rather than | ||
|
|
@@ -72,4 +74,5 @@ target_link_libraries(example_dial | |
|
|
||
| target_link_libraries(example_module | ||
| viam-cpp-sdk::viamsdk | ||
| gRPC::grpc++ | ||
|
||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,13 +236,13 @@ target_link_directories(viamsdk | |
| viamcppsdk_link_viam_api(viamsdk PRIVATE) | ||
|
|
||
| target_link_libraries(viamsdk | ||
| PUBLIC ${VIAMCPPSDK_GRPCXX_LIBRARIES} | ||
| PUBLIC ${VIAMCPPSDK_GRPC_LIBRARIES} | ||
| PUBLIC ${VIAMCPPSDK_PROTOBUF_LIBRARIES} | ||
| PUBLIC Boost::headers | ||
| PUBLIC Boost::log | ||
| PUBLIC xtensor | ||
| PRIVATE ${VIAMCPPSDK_GRPCXX_REFLECTION_LIBRARIES} | ||
| PRIVATE ${VIAMCPPSDK_GRPCXX_LIBRARIES} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
| PRIVATE ${VIAMCPPSDK_GRPC_LIBRARIES} | ||
| PRIVATE ${VIAMCPPSDK_PROTOBUF_LIBRARIES} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⬇️ - I have a suspicion there may no longer be any actual direct usage of abseil in viamsdk. Can you please check?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. happily you're right! |
||
| PRIVATE absl::strings | ||
| PRIVATE viam_rust_utils | ||
| PRIVATE Threads::Threads | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any actual use of grpc in this examples sources.